Rootul P
Rootul P
Fixes warnings of the form: ``` Warning: Function state mutability can be restricted to view --> /Users/rootulp/git/rootulp/ethernaut-x-foundry/src/Token/TokenFactory.sol:19:3: | 19 | function validateInstance(address payable _instance, address _player) override public returns (bool)...
Fix typo in test name. I observed this warning ``` Warning: SPDX license identifier not provided in source file. Before publishing, consider adding a comment containing "SPDX-License-Identifier: " to each...
### Problem When an engineer forks and uses this repo to start solving Ethernaut exercises, all solutions are present in the fork. ### Proposal Remove the solutions from the main...
### Preface Thanks for creating this repo, it's made tackling Ethernaut challenges more enjoyable! ### Question Are maintainers open to taking a dependency on [forge-std](https://github.com/brockelmore/forge-std/blob/master/src/Vm.sol)? That way we can remove...
I observe the following error when trying to enter insert mode in Vim: ``` Error detected while processing InsertEnter Autocommands for "*": E117: Unknown function: ale#Queue ``` I believe the...
## Description ADR version of https://github.com/celestiaorg/celestia-app/issues/659 I plan on filling out the **Implementation Details** while working on the implementation but this is ready for review and I would definitely appreciate...
## Context https://github.com/celestiaorg/celestia-app/pull/666#discussion_r959704855 ## Description We want to enable the prealloc linter to reduce PR feedback cycles and increase codebase consistency. - [ ] Confirm that `prealloc` throws a warning...
### Summary of Bug I am observing that the latest commit on `master` has a test that failed CI: https://github.com/celestiaorg/celestia-app/runs/7550586435?check_suite_focus=true#step:6:133 ``` --- FAIL: TestIntegrationTestSuite (77.44s) block_size_test.go:44: setting up integration test...
Minor grammar fixes. Thanks for your hard work on this!