Rootul P
Rootul P
## Context It looks like two locations in this repo use the `test_ledger_mock` build flag. https://github.com/osmosis-labs/osmosis/blob/3abc40e5bfdda882f15203567997468b60d33755/Makefile#L370-L371 https://github.com/osmosis-labs/osmosis/blob/3abc40e5bfdda882f15203567997468b60d33755/.github/workflows/test.yml#L101 However I don't see `test_ledger_mock` build flag specified in any `.go` files. Does...
## Context https://github.com/celestiaorg/celestia-specs was deprecated in favor of specs per repo. See https://github.com/celestiaorg/celestia-specs/issues/212 ## Problem celestia-node doesn't have a specs directory yet. ## Proposal When we create a `specs/` directory...
Closes https://github.com/strangelove-ventures/interchaintest/issues/1063 ## Testing I used this patch locally and got past the error mentioned in the issue but I'm not 100% sure everything is resolved yet b/c my test...
## Context I'm trying to use interchaintest with Hermes relayer because the default ibc-go relayer is hitting https://github.com/strangelove-ventures/interchaintest/issues/1055 and I don't know how to override the `--gas` flag for the...
Closes https://github.com/celestiaorg/celestia-app/issues/3276 I discovered one more follow-up while working on this. It doesn't look like `ResetTally` is actually invoked anywhere when I think it should be invoked [here](https://github.com/rootulp/celestia-app/blob/5d37f3e7dc1216613a4c34bf07c46543b7d76832/app/app.go#L698-L708). cc: @cmwaters
## Context https://github.com/celestiaorg/celestia-app/pull/3224 merged and there are some untracked follow ups. It seems like there's agreement on doing them. ## Proposal 1. Can we move some of the unit tests...
Fixes a few inconsistencies between the code and comments.
## Context https://github.com/celestiaorg/celestia-app/blob/1d73e334a48732ba2ef07caf064a7060175381f0/app/prepare_proposal.go#L36-L38
A few miscellaneous fixes in the README
## Context Blocked on https://github.com/celestiaorg/celestia-app/issues/3187 Currently the test only tests v1 nodes. ## Proposal Extend the test to test v2 nodes.