Rootul P

Results 300 comments of Rootul P

I'm also observing this error. go version: go version go1.18.3 darwin/amd64 ``` $ cobra-cli init Using config file: /Users/rootulp/.cobra.yaml Error: exit status 1 ```

+1 in order to query Blueprint elements via [`getByTestId`](https://testing-library.com/docs/dom-testing-library/api-queries#bytestid) which uses the attribute `data-testid`.

@adlerjohn points out two drawbacks to using named return values: > Bare returns are one big issue. The other is un-obvious side effects. Assigning to a named return value is...

> as long as we do not change tendermint code That's a really good point. Any decision we reach here would only be productive if enforced through linters. I think...

> Create own our ABCI client (we could called it Optimint or Lazymint) that is based on aggregator(s) rather than BFT consensus. Linking to https://github.com/celestiaorg/optimint which took this approach

@evan-forbes any objections to me doing this for branches that haven't been updated in the past month?

To reduce the frequency of this chore, a repo admin should enable this setting on https://github.com/celestiaorg/celestia-core/settings:

Sounds good, please assign back to me after you move branches and I can delete the remainder of stale branches

We also want to deprecate `master` to avoid links to outdated content. Example: https://github.com/celestiaorg/docs/blob/069623334073d5b2c4b626f732f016c2ede18841/docs/concepts/how-celestia-works/data-availability-layer.md?plain=1#L152

> apologies again for the delay on this No worries on the delay, this is a low priority chore. > I don't feel comfortable deleting other people's branches. It seems...