ronso0
ronso0
@Swiftb0y do you have time to review this? I'm hesitant to change the base to 2.5, don't know how this affects the review convos.
Thanks, FYI we are already in contact with Phase.
**_edit_** Thanks for offering your help @kalsifer-742 ! The Inpulse 500 mapping has been added recently: for main #14316, 2.5 backport is #14491 So I think we can close this....
> I understand that this mapping is now included in Mixxx, correct? Yes, see https://github.com/mixxxdj/mixxx/tree/2.5/res/controllers > Going forward if I want to improve the mapping, I have to create another...
Good to see you picked this up again. Just some thougts, I didn't take a closer look, yet: * the preferred way to map effect controls (espcially the ERGO's standard...
> controller mappings usually go to the stable branch (2.4 I changed the base branch here, and indeed your branch is based on main (all commits since branching 2.4 are...
@jssotomdz already signed for #12456 as Jesús Soto
All good now, thanks! Did you consider the proposed (Mixxx deafult) effects mapping? https://github.com/mixxxdj/mixxx/pull/13003#issuecomment-2021859856 I know that implementing that would mean you'd throw away of your own implementation (the script...
FYI review conversations are resolved by reviewers only (and when the contributor picks a code suggestion :| ). Otherwise it's tedious for reviewers to check whether all comments have been...
> I can test the change if you give me a hint how to do it. You can either check out the modified mapping via git/Github, or you download the...