ronso0

Results 1331 comments of ronso0

Yep, that's why this bug is still open : )

I think most of this can be done with [Mixxx filters](https://manual.mixxx.org/2.4/en/chapters/library#using-search-operators) (incl. OR operator and special BPM filtering in Mixxx 2.5+), just Mixxx has no GUI for this.

FYI you can comment code and make suggestions in the ['Files changed' tab](https://github.com/mixxxdj/mixxx/pull/12948/files). Floating code blocks and screenshots are a bit of ... slow workflow. And you can always open...

Thank you for this PR! Please sign the [Mixxx Contributor Agreement](https://docs.google.com/forms/d/e/1FAIpQLScC9QG327sjLL0eWftmfGUasxFFLxg6LCXJ2xHDYRzFIRqyiw/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ) and comment here when you have done so. It gives us permission to distribute your contribution under the GPL...

Instead of commiting through the Github web API, I highly recommend you set up `git` and work locally. For example this will allow you to run the `pre-commit` code checks...

Great, because I think all these "Update ..." commits may as well be squashed. FYI as long as a PR has not seen a review you may squash, rebase and...

Re Tap button: I see you have some logic in place to guess which deck the user wants to address. Wouldn't it simplify things a lot, i.e. make it prediactbale/reliable...

I understand that (and I understand you don't want to drop your current implementation unless strictly necessary ; ) but I think it would be much simpler: Browse and Tap...

> If I use shift+BPM to select the deck, I will need to use BPM to reset both decks, no way to of selecting which deck to reset. I thought...

I only tried to make some sugestions to improve the workflow. I think @Swiftb0y was reviewing the code.