ronso0

Thank you for this PR, this looks good so far! Please sign the [Mixxx Contributor Agreement](https://docs.google.com/forms/d/e/1FAIpQLScC9QG327sjLL0eWftmfGUasxFFLxg6LCXJ2xHDYRzFIRqyiw/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ) and comment here when you have done so. It gives us permission to distribute...

> Also I want to see how to trigger a WWaveformOverview GUI paint when clicking apply / OK on the preferences dialog This instant update would be one of the...

> WaveformWidgetFactory only deals with the scrolling waveforms. Ahmm, I was wrong: it already provides the overview waveform data and handles the `[Waveform], OverviewNormalized` setting. So actually, the alternative to...

I think the WaveformWidgetFactory signal solution is easier to implement. First I preferred to keep the overview stuff out of WaveformWidgetFactory, but actually (and since it already handles overview settings)...

This looks good, I'm also fine with white as default marker color. There are some marker offsets with long tracks, probably due to rounding  In vertical mode, the right...

Just a word on Qt Designer: that potentially rearranges the .ui files (for no reason) which produces a unreviewable diff. If that happens please resort to editing the ui file...

@presentformyfriends Merging is preferred becasue rebasing rewrites the commit history and may detach review comments (which could mean a lot / everything hd to be reviewwd again) Though, for this...

@ywwg can you still reproduce it with the S3, or with steps @benselme posted?

> I was planning on calling `slotRefreshAllRows()` in the new [`BaseTrackTableModel::setKeyColorsEnabled`](https://github.com/mixxxdj/mixxx/blob/c0657253e34f141f17a37740ef20e4e8b2790b65/src/library/basetracktablemodel.cpp#L122) method, but then realized that this method needs to be static, while `slotRefreshAllRows` is not static. I'd recommend to...

Btw the key color default is ON, but the checkbox is not checked when opening the Color pref page.