ronso0
ronso0
now it wants to move the header include... please revert and re-commit as described above, actually pre-commit should only act on changed lines. then force-push.
...and trailing whitespaces :laughing: You can also download the pre-commit patch from the CI summary (at the bottm of the Summary page https://github.com/mixxxdj/mixxx/actions/runs/8242566098?pr=12934), apply that (git commit --amend) and push...
> The error just flip-flopped on line 74 of bpmcontrol.cpp, telling me to unbreak things, now telling me to break things again. Well, sometimes it's strange. Did you apply the...
Re https://github.com/mixxxdj/mixxx/pull/12934/commits/85e97bacb4df4e20b9a6d88e29f2f00e68daae91 You can simply merge upstream/main (mixxxdj/mixxx:main), no need to create PRs for your branch.
I'm the only reviewer until now and I'm fine with cherry-picking / rebasing and amend the commit of #12941.
I assume this is the MIDI Input table. Actions are sorted by control, and IIRC that is D ouble F our thirds H alf T hree fourths T wo thirds...
I have just rebased, fixed and force-pushed to your branch. Hopefully also clang-tidy is happy now.
> I have just rebased, fixed and force-pushed to your branch. Hopefully also clang-tidy is happy now. Since I worked on this, too, someone else needs to review and merge.
I've split the commit into the std::unique_ptr changes and the actual feature commit.
> We have a conflict unfortunately resolved. There'll be _some more_ #12104 when this is merged :sweat_drops: