ronso0
ronso0
Thanks for applying all the fine tuning I suggested! I take a final look once #12296 has been approved.
Hmm, pre-commit is complaining, please run it locally or apply the patch generated by CI https://github.com/mixxxdj/manual/actions/runs/10973237220?pr=592
I know, pre-commit points to other lines, just check the patch https://github.com/mixxxdj/manual/actions/runs/10973237220/artifacts/1961733470
> Do i need to add the sampler control target ? Yes, stars controls are added for all decks (it's added [here](https://github.com/mixxxdj/mixxx/blob/ada244c233bc96d27420a70f404c578e6b706840/src/controllers/controlpickermenu.cpp#L1396) and `addDeckAndPreviewDeckControl()` adds the control for all players)...
> Is 2.4 the default branch or is it main ? Good you asked (I'd almost have merged this to main): Current stable is the default branch for fixups, so...
Sorry this got little attention lately, there were PRs with higher prio for 2.5 This is a new feature and should therefore actually go to main. However, no official 2.5-beta...
oh, sorry, I confused with the controls PR https://github.com/mixxxdj/mixxx/pull/13077
Just a quick note regrading the images: it would be preferred to create rather small SVG overviews instead of adding ~1 MB PNG images to the repo. You can create...
Re the schematic overview: correct me if I'm wrong: the Platinum FX is identical to the Pro FX except it has jog wheel displays. So we can use the Pro...