ronso0

Results 1331 comments of ronso0

Yes, I think so. I'm not aware of plans to remove those controls.

Oh, an unexpected effect of #12657 The errors indicate that the FLX4 mapping expects 16 samplers, but it doesn't set `[App],num_samplers` accordingly. Only the default minimum of 4 samplers has...

Actually, the FLX4 needs to be adjusted. It should use the same iterator as other mappings: https://github.com/search?q=repo%3Amixxxdj%2Fmixxx+num_samplers+path%3A%2F%5Eres%5C%2Fcontrollers%5C%2F%2F&type=code https://github.com/mixxxdj/mixxx/blob/7b3e48544a5a5475553742678115951179c41526/res/controllers/Reloop%20Terminal%20Mix%202-4.js#L89-L91 https://github.com/mixxxdj/mixxx/blob/7b3e48544a5a5475553742678115951179c41526/res/controllers/Hercules-P32-scripts.js#L51 https://github.com/mixxxdj/mixxx/blob/7b3e48544a5a5475553742678115951179c41526/res/controllers/Stanton-DJC-4-scripts.js#L90

Maybe this is an edge case but it seems to apply to a few mappings I think: a mapping connects to the the number of available samplers (e.g. Shade skin:...

@rjpence How this that relate to the samplers issues?

I can not reproduce this (with 2.4). Could you attach a small screencast demonstrating the issue?

Might be related #12467 Issue was gone after a library rescan.

You can safely test other versions if you backup your data, and roll back if you go back to the stable version. https://github.com/mixxxdj/mixxx/wiki/Testing

Can confirm the playcount issue, repaint on selection change (bold) works though. Crates are not affected, so it's probably some issue in [PlaylistFeature::slotPlaylistTableChanged](https://github.com/mixxxdj/mixxx/blob/7b3e48544a5a5475553742678115951179c41526/src/library/trackset/playlistfeature.cpp#L326) and/or [PlaylistFeature::constructChildModel](https://github.com/mixxxdj/mixxx/blob/7b3e48544a5a5475553742678115951179c41526/src/library/trackset/playlistfeature.cpp#L284)

> Can confirm the playcount issue, repaint on selection change (bold) works though. > > Crates are not affected, so it's probably some issue in [PlaylistFeature::slotPlaylistTableChanged](https://github.com/mixxxdj/mixxx/blob/7b3e48544a5a5475553742678115951179c41526/src/library/trackset/playlistfeature.cpp#L326) and/or [PlaylistFeature::constructChildModel](https://github.com/mixxxdj/mixxx/blob/7b3e48544a5a5475553742678115951179c41526/src/library/trackset/playlistfeature.cpp#L284) or https://github.com/mixxxdj/mixxx/blob/99bc5c200a8672ac99e80588aa7aea6c43bdfde9/src/library/trackset/playlistfeature.cpp#L203...