ronso0

resolved by #11251

Alrigth, so I wrapped my head around this stuff again, finished it and I adjusted the PitchRoundTrip test accordingly. Rebased onto 2.4 Only ToDo left is - [x] add test...

Reminder: to simplify testing I added key lock & unlock mode toggles, `pitch` and `pitch_adjust` sliders to LateNight. Need to remove that commit before merge!

Everything still looks okay when testing with my script. I'll give this a more thorough spin next weekend with my controller. I added a simple test for KeepLockedKey mode and...

> I am unsue what is desired in the middle ground of not putting sliders out if sync but also start with a new track without supprises. I'm not that...

``` /home/runner/work/mixxx/mixxx/src/test/enginebuffertest.cpp:62: Failure Expected equality of these values: 0.5 ControlObject::get(ConfigKey(m_sGroup1, "pitch")) Which is: 0.5 ``` ?? Test passes only on macOS ARM

> Everything still looks okay when testing with my script. In a manual test though I ended up with pitch_adjust != 0 again (couldn't reproduce until now, but I didn't...

> ``` > /home/runner/work/mixxx/mixxx/src/test/enginebuffertest.cpp:62: Failure > Expected equality of these values: > 0.5 > ControlObject::get(ConfigKey(m_sGroup1, "pitch")) > Which is: 0.5 > ``` > > ?? Test passes only on macOS...

I'm still into finishing this, though I paused because it wasn't itching me lately (only used one setup) and IIRC some aspects of profile loading / device parsing would require...

The debug assert in `CrateFeature::activateChild` needs to just return for crateId = -1 (Archived item) 27e625a28cf It would be a nice addon if the table view is cleared when clicking...