ronso0

Currently the `---` item can also be selected with `[fx_unit],next_/previous_chain_preset` and `[fx_unit],preset_selector`. I don't consider that a good solution and would like to prevent that, though if it's desired I...

I don't have any expectations this will get merged soonish, so no need to excuse and no need to hurry. I just gave this another shot while I'm still into...

> I experience a segfault: This happens after selecting a new effect before it was "---" Yep, already fixed. incorrect usage of `isReadOnly()`

Note that I need to rebase anyway to remove the skin debug commit. I'll make fixup commits for all proposed changes and squash on final rebase. Alright?

For debugging / stress-testing I added a complete QuickEffect rack above the decks in LateNight.

> ~Exposing all the effects and parameters within QuickEffect chains makes them no longer any different from regular effect chains, which therefore makes them pointless.~ > > Sorry, I didn't...

`[fxChain],chain_preset_selector` is broken now: it get's stuck due preset (empty string) not being found in the presetlist (presetIndex() returns -1) [here](https://github.com/mixxxdj/mixxx/blob/a8440945ae8aef3f629768b6f0836b0edc145745/src/effects/effectchain.cpp#L329-L340). Here, this happens because the preset name was changed...

I doubt this is the appropriate fix for the issue. FWIW in dev tools I see `chain_preset-selector` twice for each unit/chain **Edit** appearantly this is true for all aliased controls.

Recent changes, besides fixups: * `---` is re-added to standard and QuickEffect preset lists when changed lists are pushed back from effect preferences to EffectChainPresetManager (which updates the preset lists...

**TODO** - [ ] remove skin commit