ronso0

Results 1331 comments of ronso0

Thanks for your continuous work on this! It doesn't build, did you forget to commit something? Why a WidgetGroup (that doesn't seem to be set up), doesn't it suffice to...

Ah okay, I wasn't aware of the context, thanks for the clarification. AFAIK the key-related design process happend on Zulip, so maybe we should stick to that, idk. I agree...

> Did you consider how to show off tune keys? What about painting the upper 1/5 of the bar in a contrasting color?

Just a heads-up: in my personal branch I have [3c02a0a LateNight: add key offset indicator](https://github.com/mixxxdj/mixxx/commit/3c02a0af3de7798dea7575952fe9dbe8046d5869) which makes key controls complete for me (I often forgot to reset the key on...

You could create a `QStyleOption` and do all kind of cusotm painting with it. See `WSliderComposed::paintEvent()` for example.

A separate widget would also work, but requires skin changes (for example in LateNight, WKey is styled like a text edit and we'd need to adjust the key color bar...

I think you can retrive the rect inside the borders so the color bar is inside, not "attached" to the entire. This way we could use WKey as before and...

Oh, this has been waiting way too long. @danferns Are you still around and want to finish this? Taking another look I noticed that f7b9aa1f1b703747f9716387dcfb827dd1e73630 wil break controller scripts and...

Great, thanks! I think you can squash all commits now. I'll test later on.

LGTM, just a minor issue. Unfortunately the key bar is painted immediately when enabling key colors in the preferences, it's updated on next pitch change, but that's a minor issue,...