Results 1611 comments of Roman Ivanov

>Trailing whitespace is not allowed [noTrailingWhitespace] We usually do not run checkstyle on Inputs, as they are weird by design. The more weird the better. Please fix pitest.

@0xbakry, please make other CI green. At the end maintainers can copy your code to other PR to check circleci

Yes, non of them related, just known CI issues

ok, code is ok, lets wait for diff report that will prove no regression.

Please add to your input file cases: https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/658bb6b_2024172041/reports/diff/openjdk17/index.html#A2 https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/658bb6b_2024172041/reports/diff/openjdk17/index.html#A5 https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/658bb6b_2024172041/reports/diff/openjdk17/index.html#A49 After update no need to regenerate report. Report is good , I don't see problems, great job!

Please finish issue update, we need to get label of approval, to avoid refactoring of this PR.

we still in misalignment on expected behavior. see https://github.com/checkstyle/checkstyle/issues/2827#issuecomment-1817527323 and I more like update like you did at https://github.com/checkstyle/checkstyle/pull/13968 but lets see if we can get approval from others.

issue is closed by author, to cover what was required we just need to use different check - https://github.com/checkstyle/checkstyle/issues/2827#issuecomment-1817527323

>constructors are not in order What order of ctor we expect? From less parameters to more parameters? I do not think we do this for methods. Did you mean we...