Results 1611 comments of Roman Ivanov

@nrmancuso , we are in disagreement, please share second opinion on this PR. My position is to ease problem for all contributors while we dealing with big gap in our...

> Also, we need agreement to also take an iterative approach to this issue in general, and move forward with https://github.com/checkstyle/checkstyle/pull/12511 even if it is not perfect. I already posted...

@rnveach , please consider PR one more time.

still issue on 0.12 - https://github.com/checkstyle/checkstyle/pull/7524#issuecomment-580818522 @hcoles , we appreciate your feedback on this issue. Declaration code is marked as survived: ![image](https://user-images.githubusercontent.com/812984/73564529-a070c080-4414-11ea-927b-659e2eae8ea4.png) BUT there is no red lines(detailed list of...

demands of such `set -e `s will be super awesome by option. presence of `|| true ` or `grep ....| cat` is separate problem that easy to catch during code...

Some internal immutable collection is good for engineers express intend, such details might not be easily testable from public methods. I think it is same level of restrictions that engineers...

@hcoles , please share link to some doc or please share how to use ? Or where to put "+funmodifiablecollection" ? We use maven. Thanks a lot in advance. May...

@hcoles , one more fix is required Please look at https://github.com/checkstyle/checkstyle/pull/14484#discussion_r1490310155 Look like you covered the only when code is ` return ....;`

there is another evil "single return from method" , but we refactored it to java8 style of code to reconcile. I pretty sure there will be numerous examples where usage...

still mutation survival: https://github.com/checkstyle/checkstyle/actions/runs/7916871513/job/21611685470?pr=14484#step:6:458 ``` Source File: "DetailAstImpl.java" Class: "com.puppycrawl.tools.checkstyle.DetailAstImpl" Method: "getHiddenAfter" Line Contents: ".map(Collections::unmodifiableList)" Mutator: "org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator" Description: "replaced call to java/util/Optional::map with receiver" Line Number: 514 ``` java: ```...