Roman Ivanov
Roman Ivanov
@martin-mfg , ping. Let me know if something is not clear.
@martin-mfg , if you allow maintaners to change your repo, it would be awesome problem: https://github.com/checkstyle/checkstyle/runs/2905546480?check_suite_focus=true#step:6:24 sorry for being slow to reply to you.
@martin-mfg , please review failure of https://checkstyle.semaphoreci.com/jobs/42f5e408-f8e4-43d7-be56-ea2118570d69 did we miss some update ? for xwiki failure: `Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.xwiki.commons:xwiki-commons-pom:pom:13.7-SNAPSHOT` we do not have this problem...
we recently run into edge case with `scope` property but for another Check - https://github.com/checkstyle/checkstyle/issues/13749 , and I am not sure how accessModifiersOption is going to handle it.
I restarted semaphore, I fixed distance project problems.
@0xbakry @nrmancuso , please read https://github.com/checkstyle/checkstyle/issues/12600#issuecomment-1529114076 We will merge this PR, but it might be much better to completely remove such validation from this Check to not confuse user, there...
CI is red , please fix it.
You are close to green CI. Still 2 items to cover by tests https://github.com/checkstyle/checkstyle/actions/runs/7556390072/job/20573295075?pr=13037#step:7:23