Roman Ivanov
Roman Ivanov
@sheetalj2205, we are ready to start removal. Referenced PR is merged.
We need to remove all `//ok` comments and keep only comments that some text after it like `//ok bla bla bla`
@sheetalj2205, just make comment "I am xxxxxCheck tests" and send PR for single Check only. After we merge first PR you can send PRs for more, by group. We do...
No assignments, just make a comment what check/module you are going to work and keep sending PRs. Thanks a lot for helping.
Just start sending PRs.
@nrmancuso , I think we are not continuing with String Template. Should we close this?
if no reply in 2 week, PR will be marked as abandoned.
I approved issue to fix what we detected/detecting manually. It can be long ongoing issue with many PRs
I want to re-question necessity of this issue. detected at https://github.com/checkstyle/checkstyle/pull/14633/files#diff-624d1aa1b8e49bbaed857fe116c7d91c06325ed8c348393eab80a03a5e6b1f87R17 ``` - public class InputMagicNumberDefault3 { + public class InputMagicNumberCheckHashCodeValue { ``` InputMagicNumberCheckHashCodeValue is not valid name as there...
I see how people are struggling to do updates for this issue. I also struggling to suggest better name. I don't see future of such updates. All existing are ok...