Roderick van Domburg

Results 376 comments of Roderick van Domburg

It’s been fixed in #786.

Sure, I'd be open to that if someone would put in a PR for it. I don't have hardware to test that on myself.

I vote for removing `minimp3`. Any community effort is better spent on improving pure Rust Symphonia than reviving C-based `minimp3`.

The recent maintainer has added in https://github.com/germangb/minimp3-rs/pull/51: > [!CAUTION] > This crate is not recommended for new projects due to multiple memory > unsoundness issues and the availability of mature,...

It's currently hardcoded: https://github.com/RustAudio/cpal/blob/1c9c642bb31907df03e4d62063bc344fde539591/src/host/coreaudio/macos/mod.rs#L673 Could be knob to add in #1010.

> I tested all bevy examples while patching this branch and [rodio's](https://github.com/RustAudio/rodio/pull/803) too and everything seems to be working as expected. Thanks for the feedback. Shall we slip in #1070...

Last call for testing: aiming for asio-sys 0.2.4 and cpal 0.17 release tomorrow.

First a bit of a low-effort but hopefully high-impact reply: does looking at https://github.com/RustAudio/cpal/pull/938 help? That implementation is not perfect, but the use of `pipewire::buffer::Buffer` seems interesting. In your fork...

Format-native seeking would be great, but without it, you can still build a looped decoder with Rodio.

It's when a span ends at which point it's no longer guaranteed that the channel count and sample rate are the same, and it has to re-init to adapt. We're...