Roderick van Domburg
Roderick van Domburg
@setoelkahfi I'm going to close this, assuming that the new limiter satisfies your needs. If not, feel free to reopen and clarify the different or additional scope you're after.
> @roderickvd this PR can probably be considered ready. The only missing feature is to handle the track list. It can probably be done in another PR. Thanks! I saw...
Don't forget to add a changelog entry.
👍 I’m away for a few days before I can review, but if anyone wants to beat me to it…
Reading the comments above I think you guys may already be aware, but just to make it explicit: we should not rely on sources providing full frames. Frames could be...
> It might be worthwhile to define what we are talking about, you seem to be talking about external sources? The discussion above is about the rodio `Source` API contract....
> > Another is malformed data. If Rodio makes strict assumptions about that today, then this could already be an issue today. Of course most sources are well-formed, and frames...
> > Another thing to think of is that when we check for parameter changes on every frame this may prevent some compiler optimizations. > > I do not really...
😅 it was a hunch that the queue would be cleared and playback stopped when we properly handle a disconnect event. And so it did…