Roderick van Domburg

Results 376 comments of Roderick van Domburg

Note to self: consider making configurable whether CoreAudio follows default audio device changes or not (#1012).

Instead of this we could use extension traits. These would add backend-specific methods without polluting the core trait: ```rust // Core trait - stays platform-agnostic pub trait DeviceTrait { fn...

From a code review this looks good. Can we add some tests, also for rollback scenarios? Question I've got is: what do we do when a rollback fails? Currently it...

Yeah, that's interesting. Although relative seeks should work right? I was naively only thinking about all sources having a common T=0. We could make this _very_ complex. Even relative seeks...

> Lets see if we can find some middle ground that covers most (simple) use cases. All for it. I just don't know (as in "have knowledge of real-world usage")...

I'd like to have this issue dug a little deeper before switching defaults again. First, to understand. Second, because unlike MP3, Ogg Vorbis files should have their duration reliably determinable...

Yes, clearly the span length. Thanks for that quick debugging. Haven't gotten around to it yet, but my hunch is that the first chunk of Ogg data does not contain...

Hypothesis confirmed, I'll submit a PR soon.

Working on this I got carried away :laughing: so a pretty large PR is incoming to fix alongside a host of other improvements.