Roderick van Domburg

Results 379 comments of Roderick van Domburg

I support this for reasons of clarity and code robustness. > Performance might drop in decoders, the current implementation makes the bound check every time `channels` or `sample_rate` is called...

When I read the title of this PR, I thought _**yes please**_ as you know I am on the position that span constructs are fraught with peril, trying to guarantee...

> The dev could make sure every source is the same sample rate and a constant one. Then you would only need a resampler at the root of the tree....

The problem is not dns_sd, it's this: ``` [2025-08-29T09:50:29Z INFO librespot_playback::audio_backend::rodio] Using audio device: default ALSA lib confmisc.c:855:(parse_card) cannot find card '0' ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM default ``` Something...

I see, that indeed changes matters. When running `librespot` vanilla, please select that "pipe" backend also so it's fully reproducible. - Is `avahi-daemon` running? - Which was the latest version...

Possibly this should fix your problem: https://github.com/librespot-org/librespot/issues/1133#issuecomment-2041229773 I don’t know how Homebrew works with options. You can compile librespot yourself following the instructions in COMPILING.md.

> > Finally, `try_seek` should provide deterministic seeking (same results after seeking) > > should it? I've never seen seek as reproducing something rather navigating in an underlying stream. I...

> If we can not find a good use case now I would propose we scrap determinism. We can always add `deterministic_noise` later that goes through all kinds of complex...

> Isn't it strange to then disable seeking as soon as a piece of audio gets **mixed** with noise? [emphasis mine] Are you referring to `Mix` specifically? Because `Mix::try_seek` currently...