Roderick van Domburg
Roderick van Domburg
Superseded by #1366
Probably you could also make `hifi_rubato` work over all sample types by making it generic over `Sample` and calling `to_sample` on its input and output? For `Sample` that will be...
I was looking at `dasp` when I saw it also features an iterator-style Sinc interpolator: https://docs.rs/dasp_interpolate/latest/dasp_interpolate/index.html As Rodio is relying on `dasp_sample` anyway, do we want to more generally want...
By contract, `Iterator::size_hint` returns `None` for its upper bound when it would exceed `usize::MAX` (like infinity). Not saying that `Source::total_duration` needs to follow that, but there's some appeal to following...
It's a nice idea. Generally we'd need to calculate RMS, apply a FIR/IIR filter, possibly by chaining biquads, and build a histogram. Then depending on which standard or weighting we'd...
Ah I had only clicked the C link. Yes let's reuse what's there!
> For a (worse in my opinion) alternative see: #747 I agree that maintaining our own counter sucks, like in #747. But so is pulling in another dependency, kinda... it's...
Argh, what a pain. Well, if this is the lesser of evils, so be it.
> Still in favor of this PR, though I really don't like making every downstream user add a custom drop implementations to whatever they are storing our `OutputStream` in..... The...
> maybe there is a middle ground: We emit a warning on drop unless close is called. Its not as disrupting as a panic but it could still help out...