Chris Roche

Enum aliases not supported

3

Using protolock v0.15.0, with the following proto: ```proto syntax="proto3"; enum Foo { BAR = 0; BAZ = 1; } ``` After committing the lockfile, and making the following (backwards compatible)...

Removing entire message triggers NoRemovingFieldsWithoutReserve

10

For the following test file: ```proto syntax = "proto3"; package foo; message Bar { int32 baz = 1; } ``` Running `protolock init`, then deleting message `Bar` entirely. Then running...

Well Known Regex Validation

3

Re: https://github.com/envoyproxy/envoy/pull/2420#discussion_r162995905 Add well known validation rules for regular expressions. On the Go side, supporting RE2 is a nominal effort, and likewise if the C++ code uses RE2 as well....

buf breaking - Better UX around proto3 optional fields

1

Running breaking change detection with `FILE` rules, if a proto3 optional field is moved into a oneof, `buf breaking` correctly identifies the incompatible change, however the error messages can be...

Received a few reports where folks are confused where this project ends and [`protovalidate`](https://github.com/bufbuild/protovalidate) begins. To help guide folks gently in the right direction, we should warn in PGV if...

Improve language around keyspace notifications

2

Effectively, replace usage of the word `sensible` (which means "practical" and not "able to be sensed") with `perceptible`. This threw me for a loop on first read. 😅

Data race: lock on abort/complete of multipart upload

2

Hi, Thanks for this great module! Ran into a data race while interacting concurrently with the multipart capabilities. It appears that the uploader lock is not consistently obtained when completing...

[checklocks] Annotations ignored on generic structs

3

### Description It appears `checklocks` (sha: [`69e0c7643d821f03ed797ea3911f6ab458e2a2d6`](https://github.com/google/gvisor/tree/69e0c7643d821f03ed797ea3911f6ab458e2a2d6/tools/checklocks)) fails to recognize annotations on generic types. For the following code: ```go package example import ( "sync" ) type X struct { mu...

[Feature Request] Add skipped_fields field constraint for finer-grained skipped behavior

4

**Feature description:** Today, we support the `skipped` standard constraint on message fields to skip any validation constraints applied to the underlying type. This is currently an all or nothing scenario,...

Document recommendation for instantiating/managing validator instances

2

Title. A few strategies are available, but want to encourage folks to reuse a validator instead of creating a new one for every call to Validate.