protolock icon indicating copy to clipboard operation
protolock copied to clipboard

Enum aliases not supported

Open rodaine opened this issue 4 years ago • 3 comments

Using protolock v0.15.0, with the following proto:

syntax="proto3";

enum Foo {
  BAR = 0;
  BAZ = 1;
}

After committing the lockfile, and making the following (backwards compatible) changes:

syntax="proto3";

enum Foo {
  option allow_alias = true;
  BAR = 0;
  BAZ = 1;
  QUUX = 1;
}

Running protolock status, we get the following error:

→ protolock status
CONFLICT: "Foo" field: "QUUX" integer: 1 has an updated name, previously "BAZ" [foo.proto]

rodaine avatar May 21 '20 18:05 rodaine

For details on enum aliasing: https://developers.google.com/protocol-buffers/docs/proto3#enum

rodaine avatar May 21 '20 18:05 rodaine

thanks for reporting, I will take a look asap. turns out I configured github to stop notifying me for all repos? oops.

nilslice avatar Jun 15 '20 22:06 nilslice

quick update -- I haven't had a chance to really dig in here.. if anyone else feels like they want to give it a shot, please do!

adding the help wanted label

nilslice avatar Aug 03 '20 17:08 nilslice