Rob Ede
Rob Ede
Still a strong appetite from my end to see this feature released. Looks like we've avoided merge conflicts so far so I guess it's just waiting for a contributor review...
Any quick thoughts on the feature gating point above @tarcieri ?
I forked this PR and made the requested hazmat feature guard changes here: #735
New actix-identity release published: https://github.com/actix/actix-extras/releases/tag/identity-v0.8.0 Sorry for the delay.
Usage of NamedFile here is preferred. We should update the instructions to include a `cd` command.
I guess what we want is something similar to actix-web-actor's [WsResponseBuilder](https://docs.rs/actix-web-actors/latest/actix_web_actors/ws/struct.WsResponseBuilder.html) in actix-ws.
agreed, this is satisfied by #430
Just come back to this and I still like it, but I'm going to make the `Location` (and possibly `ContentLocation` after some more research) use `url::Url` instead of `http::Uri` so...
Run into a hurdle with that idea, that `url::Url` doesn't support relative references, e.g.: `/new-path`. So both types seem incapable of expressing what we actually want from Location/Content-Location.
syn:  🎉 nice work @DCjanus