Rob Ede comments

Results 360 comments of


                                            Rob Ede

uploaded example using JWT and Rusqlite for authentication

if you're interested in this being accepted still, can you please: - move it into the auth/ dir - give it a shorter name - add a readme (see other...

Using `()` as the default Message result type

There's an argument that using a default value and allowing the `[rtype=...]` attribute to be omitted would make code less obvious, especially if `Message` is hidden in a bigger list...

Transaction declined reasons are incomplete

`INVALID_CVC` is also a possible result

override default healthcheck support

Is there any reason not to just change the current health check query to `SELECT 1`?

override default healthcheck support

Even better, would be nice if `ping` returned `Result` then it would be a no-brainer to switch to. For now I'm tempted to change it to `SELECT 1`.

override default healthcheck support

Pushed a change that: - uses more standard type naming - changes the signature of `HealthCheckFn` to a function pointer - this is equivalent in the fns it accepts to...

override default healthcheck support

@outersky curious what you think. I'm hesitant but seems that my PR https://github.com/blackbeam/rust-mysql-simple/pull/355 to change the `.ping()` signature is slow going so might be a nice QoL change, for now...

override default healthcheck support

Also for the CI fail: We'll rebase this after #37 is merged.

override default healthcheck support

superseded by #38

actix-test: allow the configuration of the TestServer address

thanks for the addition 👍🏻 looks like it needs a quick look at the new test failure