Rob Ede comments

Results 360 comments of


                                            Rob Ede

Add feature for limit request to log in middleware logger using status code

The only problem I see with this is the issue of disjoint ranges. I can see it being reasonable to want everything except redirects being logged; in which case it's...

Scope macro

Done a bit of re-organization and docs tweaking. Think it's in a good state to merge. One more thing I want to add is to disallow trailing slashes to align...

Connecting to the database from an external network causes a spike in connections

This doesn't relate to Actix Web. Please ask the `mysql` crate maintainers about its behavior when it the `Pool` is dropped.

chore: update http crate

There's no security risk of staying on v0.2. It's my opinion that it's not worth a breaking change just for this. The ecosystem churn of releasing Actix Web v5.0 is...

chore: update http crate

Sorry, but compatibility with the `hyper` ecosystem isn't one of my concerns. I disagree that `http`, despite its name, should be considered as highly as "the standard library" for HTTP...

Add pattern syntax for optional trailing slash

@deepto98 mostly actix-router's ResourceDef... it's very well documented but lmk here or in Discord if you have questions

feat: add ability to specify log level for access logger

Thanks for the work you've put into this. I'm planning on migrating all the actix/* codebases over to `tracing` gradually, but dynamic logging levels is not something that's well supported...

Content_Disposition should NOT be mandatory on Multipart

released in v0.7.0

feat: change log level based on response status code

In middleware, any response (regardless of status code) that is sent is considered a success. Logging as INFO level is the policy of _this_ textual logger. If you want to...

feat: add tera filter for ordered commit groups

Yea idea of the non-breaking path is to require a different filter. The current `groupBy` behavior would remain the same.