Robert Knight

Results 728 comments of Robert Knight

I created https://github.com/hypothesis/client/issues/5201 as a sub-task for exploring the aforementioned ImageTextLayer-based solution.

I moved this to the backlog as I am not actively working on it.

Does using the "a" / "h" keys to annotate still work?

That's not a standard build of the Hypothesis client shown in the video, which also probably means it is not based on a current version. The controls in the standard...

In that video I see two highlights created and saved and two notes created, but not saved. After the navigation away from the page and back to it, only the...

I'm not sure about this. Scrolling to the newest or oldest update seems like it would feel more predictable to me than scrolling to whichever happens to be nearest in...

> We have seen people who never close it afterwards, and just continue working, creating annotations and interacting with the document, with it opened forever. Is this actually causing a...

Thanks for the bug report @heatherstaines , I was able to reproduce in Chrome 65 using the Hypothesis extension v1.62 on that specific URL. With Chrome's profiler active while making...

I can still reproduce this with the current version of the client in Safari.

Hypothesis sets a non-writable property on the sidebar iframe specifically to avoid pywb messing with it. See https://github.com/hypothesis/client/blob/1e02301eeca096d14648a33980688a8a315f6cd8/src/annotator/sidebar.tsx#L93. We could avoid the error here by making the `allow` property writable,...