Robert Knight

Results 728 comments of Robert Knight

To clarify the issue here, since we recently rounded many UI elements, including menus, the up-pointing arrow situated near the rounded corner on the right now looks a bit out...

A sketch of what this could look like, where we show the most common document title from the export data. A variation where we show a summary of what is...

Note from a discussion earlier this week. The consensus was definitely to go with something more like the second example from https://github.com/hypothesis/client/issues/5791#issuecomment-1706521744.

To recap, the current plan is to show information about what is in the selected file underneath the input, but above the user list. We need a design for how...

This is actually a valid issue. I can reproduce in Safari. The problem is that the page sets a `cross-origin-opener: same-origin` header, which prevents the login popup window from interacting...

Chrome are currently exploring a solution for this via `Cross-Origin-Opener-Policy: restrict-properties`. See https://developer.chrome.com/blog/coop-restrict-properties/. The next step for us here is to explore whether we can leverage `restrict-properties` in the context...

In the case of browser extensions, there is a built-in API for completing OAuth login flows - [`chrome.identity.launchWebAuthFlow`](https://developer.chrome.com/docs/extensions/reference/api/identity#method-launchWebAuthFlow) we might be able to use that instead of opening the popup...

I've been looking closer into using alternative communication channels (eg. `BroadcastChannel`) to pass the cookie back. What I have found is: - The sidebar cannot use `BroadcastChannel`, `localStorage` or other...

> The preferred solution here would be that https://hypothesis.vitalsource.com/ changes the Hypothesis client configuration depending on whether it was launched by our LMS app or not. Depending on how authentication...

This is super low priority IMO, so I'm taking it out of the current sprint.