client icon indicating copy to clipboard operation
client copied to clipboard

Adder occluded for certain gh views - z-index issue?

Open dwhly opened this issue 2 years ago • 4 comments

When trying to annotate a gh draft the modal is over top of the adder.

Image

dwhly avatar Jul 11 '23 13:07 dwhly

Does using the "a" / "h" keys to annotate still work?

robertknight avatar Jul 11 '23 13:07 robertknight

Yes.

dwhly avatar Jul 11 '23 13:07 dwhly

I can reproduce:

  1. Go to https://github.com/orgs/hypothesis/projects/120/views/1
  2. Click on a single issue so it opens
  3. Activate Hypothesis
  4. Highlight the repo name and issue number at the top of the issue
  5. The Adder is hidden behind the issue: Screen Shot 2023-08-03 at 4 37 26 PM

There are some strange z-indices on this page, but I can't tell if they apply to the popped out issue or not.

mkdir-washington-edu avatar Aug 03 '23 20:08 mkdir-washington-edu

I can confirm this is a z-index issue. The element rendered over the adder has z-index: 10 (one of its parents, actually), while the adder has z-index: 3. Increasing it to something >10 fixes it.

acelaya avatar Aug 04 '23 06:08 acelaya