Ruslan Hrabovyi

Results 141 comments of Ruslan Hrabovyi

The other intriguing question to me is what are our options to host the new docs. Should we preserve the old guides with some clever redirect mechanism(for SEO) or is...

> The addon docs leverage the test's dummy app directly, which uses the addon's devDependency ember version. Ember cli addon docs uses contextual components which locks you into 2.3+. If...

https://github.com/san650/ember-cli-page-object/issues/198 related.

I think we should have a way to describe where an element id can be found. So `id` field sounds like a good candidate for a default collection DSL to...

> I'm wondering if it would make sense to split the core functionality for creating and querying page objects into a separate non-ember node package. Yes, definitely! My current intention...

@NullVoxPopuli I believe, exposing an under-the-hood DOM element is a violation of the basic page object idea to abstract an implementation from the test. Typically when you change implemetation, you...

Yes, it does, but "qunit-dom" still doesn't seem to be a solution. Let's assume, you have: ```js const page = create({ hasSomeState: hasClass('someState') }) ``` "qunit-dom" would not allow us...

Exactly! A while ago I've made a quick poc for this https://github.com/ro0gr/ember-qunit-page-object, and in general, this direction looks promising to me. Unfortunately I still don't have enough time to renew...

> requires all the assertions to be wrapped in an arrow function provided to .as() I don't think `as` should be required

I think it was just a single test, but you can find another tests w/o `as` there https://github.com/ro0gr/ember-qunit-page-object/blob/d17d2e60a37612acd99f86589f1ac500a7a0f473/tests/smoke-test.js#L63-L67