Ruslan Hrabovyi

Results 141 comments of Ruslan Hrabovyi

@patocallaghan I'd love it to become v2 addon before releasing the new major. But don't want to have it as a requirement, cause TBH, I'm not sure if I manage...

I've created an issue for migration https://github.com/san650/ember-cli-page-object/issues/575

Sorry for delay. Yes, I'd prefer to use the object spread approach as you referred above. Unfortunately, I doubt if it can be just cherry-picked, cause of many changes in...

hm.. that's surprising to me. I believe that `matchExact` behavior should have been a default. But changing it now, would probably break some test suites..

just realized we could add support for this directly to the `clickable(`: ```ts const p = create(); await p.click('Some button text'); ``` fortunately, currently `click(` does not support any arguments,...

Curious, if there are any real use cases for `matchExactly: false`, which is the only possible behavior currently? I'm considering a breaking change in v2, in order to make `clickOnText`...

Thanks for reporting! This is surprising to me. I didn't know that jquery uses `textContent` for the `text(` https://github.com/jquery/jquery/blob/e35fb62db4fb46f031056bb53e393982c03972a1/src/core.js#L276. I think replacing our current usage of the `$.text(` with the...

oh.. I've just faced the issue when upgraded ec-page-object in a lib from 1.16 to 1.17. This seems to be a regression introduced in https://github.com/san650/ember-cli-page-object/pull/466 I believe we should revert...

@Alonski sorry for the late reply. Yes, I believe, basically, we just need to drop `innerText` in favour of jquery's `.text()` method for now. A thing I'm worried about at...