Ruslan Hrabovyi

Results 141 comments of Ruslan Hrabovyi

This is one of the aged issues https://github.com/emberjs/ember.js/issues/16349

Unfortunately it doesn't seem to be fixed. I've just installed `[email protected]` and the following code snipet: ```js var sass = require('node-sass'); var result = sass.renderSync({ data: `body { --c: 1,2,3;...

@Jordaneisenburger definitely not a solution, but defining custom `rgb`/`rgba` functions which accepts a single argument allows to work-around the issue for us: ```scss @function rgb($r, $g: null, $b: null )...

Just released the fix as a part of https://github.com/san650/ember-cli-page-object/releases/tag/v1.17.12

Assuming the original markup: ```js Object 1 Object 2 ``` I believe, today we can do it like: ```js const { objects } = create({ scope: 'ul', objects: collection('li', {...

I think we should deprecate `contains(`(after v2 is released) without making new `includes(` API. Users can directly use built-in string method, like `myNode.text.includes('something')`

@rtablada you are right. Let's move this forward. I've just updated bullet points with obviously missing steps. I believe mostly we should remove the remaining deprecations properly. Also I believe...

Thanks everyone for support! I think we are finally done here.

replaced by https://github.com/san650/ember-cli-page-object/pull/608

I'm surprised to hear about `maxlength` in conjunction with `type="time"` or `type="date"`. Does `maxlength` have some meaning for this kind of inputs? I've just tried: ```html ``` and seems neither...