Robert Mosolgo

Results 352 comments of Robert Mosolgo
trafficstars

I've implemented the fix in #4834, but I still need to add some way to retain the current behavior.

👋 I'm exploring options for maintaining compatibility here and I want to make sure I pick an approach that works for you. It's not as easy as passing a flag...

(I got pretty deep into RegExps and ended up landing on a stringscanner based approach instead, in 7a356ec02)

Hi! Thanks for the detailed report. Although it's in the spec, GraphQL-Ruby has never actually enforced key-value pair order in the result set 🙈 (Besides using dataloader, using GraphQL-Batch would...

> creating a new type constant which extends the original Yep, that's the only way to do it _currently_. Under the hood, the idea that each type has exactly one...

Yes, that'd be great! Can we call it `graphql_method`? That way it matches `graphql_path` & it's clear that it's the method for the GraphQL API endpoint, not for the GraphiQL...

I'm going to take a look soon at integrating subscriptions with GraphiQL, so I'll follow up here if I add Workspace!

FWIW recompiling with `be rake` again fails the same way: ``` ~/code/graphql-libgraphqlparser-ruby $ be rake mkdir -p tmp/x86_64-darwin16/graphql_libgraphqlparser_ext/2.3.2 cd tmp/x86_64-darwin16/graphql_libgraphqlparser_ext/2.3.2 /Users/rmosolgo/.rbenv/versions/2.3.2/bin/ruby -I. ../../../../ext/graphql_libgraphqlparser_ext/extconf.rb checking for cmake... yes -- Could NOT...

Here's what `be rake` generated for me: (Mainly `lib/graphql_libgraphqlparser_ext.bundle`) ![image](https://user-images.githubusercontent.com/2231765/28219368-c0ed812c-6889-11e7-9fbd-86e74d72e492.png)

I've been working on extracting features and making them opt-out-able lately, and besides that, continuing to optimize the current runtime. There's nothing else on this issue for now, besides that...