Robert Mosolgo comments

Repositories
Issues
Comments

Results 352 comments of


                                            Robert Mosolgo

Optimization - Skip processing non-existing fields in FieldsWillMerge

Thanks for this improvement!

Print warning when custom validators are detected

Hey, thanks for looking into this. What if we made `validate_timeout` I/O-safe instead? I think the visit hooks in this module could be the place for that: https://github.com/rmosolgo/graphql-ruby/blob/6120645fe4785af403bcf32ea83413fea810190a/lib/graphql/static_validation/base_visitor.rb#L55 Implementation-wise, it'd...