Robert Mosolgo

Results 372 comments of Robert Mosolgo

I'd be happy to dig deeper into whatever performance issue you encountered, but I can't proceed without more detail. Please feel free to share more info here if you want...

Hey, thanks for the detailed write-up. It seems like `NewRelicTrace` would need some way of pulling the current request info (`traceparent` and `tracestate`) out of the query `context: { ......

Hey, sorry it took me so long to come back around on this. I revisited while reworking the New Relic trace in #5240. I'm still not quite clear on what...

Hey, thanks for proposing this change! I'm definitely interested in it. Another implementation might be write a Rubocop rule which identifies and updates code that uses the "bad" approach. There...

It certainly sounds good to me... the line above is taken straight from the instrumentation's source: https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/a5648173c25576c4a2d5083958eb5ff0e7092d45/instrumentation/graphql/lib/opentelemetry/instrumentation/graphql/instrumentation.rb#L90 I think it's just a question of interface. Do you want to expose...

Hey, thanks for the detailed writeup and sorry for the trouble with that change! I have a couple of thoughts: - Yes, it would be possible to handle this dynamically...

Hey, I don't have any plans to work more on this. I'm hoping that my performance improvements to `escape_single_quoted_newlines` worked alright for you. If you find that they don't, please...

Oh! Well what if you pass the -- > This happens even if you pass all the possible_types to extra_types as well Oh 😩 . Sorry for the trouble and...

Hey, thanks for this detailed report. I agree that what you're describing _should_ work, one way or another. The workaround you found looks great to me. As you probably noticed,...

Hey, thanks again for the detailed report on this. I don't plan to prioritize more work on this, since we have a stable ~~work-around~~ solution 😅 and GraphQL-Ruby now supports...