Robert Mosolgo

Results 352 comments of Robert Mosolgo

Interesting -- thanks for sharing all those details. My first thought was, maybe it was stuck in the `while` loop here: https://github.com/rmosolgo/graphql-ruby/blob/d93e2fbab1747d46ec1089bab56e72875fd02c89/lib/graphql/dataloader/async_dataloader.rb#L38-L43 But, I see that there's a `root_task.yield` which...

I wrote a replication script, but it worked fine: Querying for currentUser.profile.id with `AsyncDataloader` ```ruby require 'bundler/inline' gemfile do source "https://rubygems.org" gem "graphql", "2.2.4" gem "rails", "7.1.2" gem "postgresql" gem...

Ugh, bummer -- the `snapshot` just showed the top-level thread waiting for the Fiber to finish. Not helpful 😖 I'm not exactly sure where to look next. I'd say the...

:+1: Thanks for the suggestion, I agree that your proposed fix would be a nice improvement. You might have to add a new parameter to `Validator.validate!` to accept the argument...

Hey! Thanks for the detailed writeup. Yes, as you noticed, there have been many attempts to match the spec on this 😅 I've created a replication script for this bug:...

I've got a fix in the works over at #4824. The most interesting part of the bug was basically that these two `.gsub!` calls resulted in a _double_-replacing of escaped...

Hey, thanks for the suggestion! My first inclination would be to keep things as they are, for compatibility's sake, but do you think there'd be a way to change it...

Hey, thanks for the detailed write-up. This is the right place for the issue -- GraphQL-Batch has done its job, now it's up to GraphQL-Ruby to resolve those promises as...

Thanks again for the detailed report. I copied your example into the GraphQL-Ruby tests and spent some time trying to understand why it's not working "properly." I couldn't quite grok...

Hey, thanks so much for this detailed report and fix. As you can see, it's been a while since I dug into the complexity implementation! I'll review these closely soon.