Richard Livsey comments

Results 27 comments of


                                            Richard Livsey

Use via RouterDSL

👍 awesome, definitely would work well as an addon. Would be great to take a leaf from the ember-power-* addons and have a page listing extensions like this. Eg [ember-power-select...

clicking buttons can cause document activeElement and selection to go out of sync

This _might_ be some strange combination of mobiledoc, ember-basic-dropdown and, bizzarely, ember-composable-helpers. When I changed the button from: ``` handlebars ``` to ``` handlebars ``` and call `dd.actions.close` inside the...

clicking buttons can cause document activeElement and selection to go out of sync

I wasn't unfortunately, no. Might be able to spend some more time figuring it out, but if you add the guard clause I can go back to that version of...

Collaboration

I'm also very interested in this and keen to help out where possible

"query param" parameters dont re-enter state

I've just run into this myself, so may as well give my 2¢… Instead of exiting/entering, a state could register its interest in a query parameter and when the state...

An extended and more robust injectScript

@nolaneo changes look fantastic, thanks! Addon version/description etc got lost in package.json after ember-cli upgrade, if you could bring those back then I'll get it merged and a new version...

Feature request: `injectScriptOnce`

Sounds good to me 👍

patch- decouple svg.js from app.js and have it as a separate file

👍 I like the direction this is going. Would be great if it didn't use the `Ember` global, this is going away in future ember releases and don't think we...

Feature Request: Co-locate SVGs within pods

👍 I've been meaning to investigate this myself but haven't had the bandwidth recently.

Option to pass styles through the `style` attribute

I'd be happy to accept a PR for this. An aside, I do wonder if this should be converted to be a component with `tagName: 'svg'`using positional parameters vs a...