ember-inject-script icon indicating copy to clipboard operation
ember-inject-script copied to clipboard
verified publisher icon minutebase

An extended and more robust injectScript

Open nolaneo opened this issue 8 years ago • 4 comments

New

  • Allows for the promise to reject if the script doesn't load.

Changes

  • Remove script from the DOM after load or failure.
  • Remove event listeners.
  • Updated to Ember 2.11

nolaneo avatar Jan 25 '17 10:01 nolaneo

@rlivsey we wrote a similar lib to inject-script @intercom. You might check out the additions and see if they're a good fit for bringing into your addon 🙂

nolaneo avatar Jan 25 '17 10:01 nolaneo

@nolaneo changes look fantastic, thanks! Addon version/description etc got lost in package.json after ember-cli upgrade, if you could bring those back then I'll get it merged and a new version released asap.

rlivsey avatar Jan 25 '17 10:01 rlivsey

Whoops, my bad. Added those back 👌

nolaneo avatar Jan 25 '17 11:01 nolaneo

Ping

knownasilya avatar Mar 15 '18 01:03 knownasilya