ember-inline-svg
ember-inline-svg copied to clipboard
patch- decouple svg.js from app.js and have it as a separate file
👍 I like the direction this is going.
Would be great if it didn't use the Ember global, this is going away in future ember releases and don't think we should hang data off it.
Maybe should just be a global constant like APP_SVGS, or wrap it in define so that it can be imported into the app vs a global?
Eg similar pattern to shims like:
(function() {
function svgModule() {
'use strict';
const SVGS = {} // the SVG data
return { 'default': SVGS };
}
define('svgs', [], svgModule);
})();
Referencing https://github.com/buschtoens/broccoli-flatiron/pull/1
any other changes to be done @rlivsey ?