Henri

Results 10 comments of Henri

> Hi! Could you remove folder helpers and bring functions to file `useFilteredApps.ts` where is used this two functions? Names like helper doesn't "help" to understand what is happening there...

Hey @paulchen. First of all, thanks a lot for finding and reporting this bug. This issue was caused by a problem between a flow router event called triggersEnter, which we...

> Do you mind changing this notation to all places that uses InfoPanel subcomponents, so we can remove the exported object from `apps/meteor/client/components/InfoPanel/index.ts` > > also prefer using `import {...

> > Do you mind changing this notation to all places that uses InfoPanel subcomponents, so we can remove the exported object from `apps/meteor/client/components/InfoPanel/index.ts` > > also prefer using `import...

> > I don't know if this PR requires a changeset. Please let me know if this is needed as it is a change in the message parser package. >...

> There's some code reviews I'd have liked to do first, but I have some questions that I must ask before. > > Where did this improvement come from? From...

> @rique223 With the introduction of SCI we're going to deprecate Current Chats, so I don't see any reason to add this feature now. Would you mind to check with...

Hey @hrabotoner, thank you so much for your contribution. The hotkey handling is done in Rocket.Chat's main code and not on electron. So you should send this issue to https://github.com/RocketChat/Rocket.Chat/issues

Dotless or no TLD emails are valid emails according to the most recent RFC regarding emails (RFC 5322), this is not a bug.

> hey @rique223 , according to RFC 5322 , a general email pattern takes this form: local-part@domain Exactly, and the email in your video follows this pattern, was it supposed...