feat: Current chats department filter fallback for department deletion

[rique223]

Proposed changes (including videos or screenshots)

Added a fallback to the current chats departments filter in which when a department is deleted and another user has the department selected in the filter, if the page is reloaded the user will be warned about the deletion and sent back to the default option of the filter.

Issue(s)

Steps to test or reproduce

Further comments

Jira task: CONN-352

[dionisio-bot[bot]]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: db833567995572aeaa176f977022ddfba3341c27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages

Name	Type
@rocket.chat/meteor	Minor
@rocket.chat/i18n	Minor
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-voip	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/core-typings	Minor
@rocket.chat/rest-typings	Minor
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions[bot]]

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33430/ on branch gh-pages at 2024-11-07 20:58 UTC

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.20%. Comparing base (f7391a4) to head (db83356). Report is 753 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #33430      +/-   ##
===========================================
- Coverage    75.42%   75.20%   -0.22%     
===========================================
  Files          493      495       +2     
  Lines        21499    21595      +96     
  Branches      5337     5362      +25     
===========================================
+ Hits         16215    16240      +25     
- Misses        4644     4713      +69     
- Partials       640      642       +2     

Flag	Coverage Δ
unit	78.94% <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rique223]

There's some code reviews I'd have liked to do first, but I have some questions that I must ask before.

Where did this improvement come from? From what I can see, there's a related issue linked in the task, but this is not a fix to that. Was this prompted from a PM or were other people involved in the definition of this feat?

Did the design team participate in this at all? At least to define the new translation?

Also, the chageset is missing. I'll convert this PR to a draft until we iron out these kinks.

Answering here for future reference: Where did this improvement come from? A: It is a related issue to the one linked in the task as the structure suggests, in this case, it causes the same problem as the linked bug but instead of being just a simple bug it also is a product gap as there was no definition for what should happen with the filter if the department is deleted.

Was this prompted from a PM or were other people involved in the definition of this feat? A: The initial idea of fixing the problem was mine with input from Aleksander but our solution was different, I took this to Renato for product input and he suggested the current flow;

Did the design team participate in this at all? At least to define the new translation? A: Yes, the text you see in the gif is from the POC, I've just shipped the new design approved copy;

Also, the chageset is missing. A: Nice catch, will add it shortly.

[dougfabris]

@rique223 With the introduction of SCI we're going to deprecate Current Chats, so I don't see any reason to add this feature now. Would you mind to check with the Product team if we could hold this one until we get the SCI code merged and introduce this feature under Omnichannel Directory chats directly? FYI @gabriellsh

[rique223]

@rique223 With the introduction of SCI we're going to deprecate Current Chats, so I don't see any reason to add this feature now. Would you mind to check with the Product team if we could hold this one until we get the SCI code merged and introduce this feature under Omnichannel Directory chats directly? FYI @gabriellsh

Hey Doug, thanks for the info man. I've talked with Renato about this and he approved waiting for SCI. I'll keep this PR on hold.