Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[IMPROVE] Change price filters for Enterprise apps

Open felipe-rod123 opened this issue 3 years ago • 1 comments

Co-authored-by: Matheus Lucca do Carmo [email protected]

Proposed changes (including videos or screenshots)

  • Currently, Enterprise apps are classified as “Free apps”. Now, they have been moved to a new “Enterprise” category in the Apps page of the Marketplace.
  • Created a new "Enterprise" pricing filter in the Apps page.
  • Added an "Enterprise" tag on the App Info page, next to the app title.
  • Removed the "Free" tag next to the install button for enterprise apps, on the App Info page.

New-version

Issue(s)

Steps to test or reproduce

  1. Go to the workspace admin panel
  2. Click on the “Apps” menu
  3. Click on the filter “All prices”
  4. Click on an Enterprise app to see the "App Info" page.

Old-version

Further comments

No changes were made for the backend logic of the Enterprise apps.

felipe-rod123 avatar Dec 15 '22 16:12 felipe-rod123

Codecov Report

Merging #27553 (51469bb) into develop (8e5a3e9) will increase coverage by 0.10%. The diff coverage is n/a.

:exclamation: Current head 51469bb differs from pull request most recent head 0493c51. Consider uploading reports for the commit 0493c51 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27553      +/-   ##
===========================================
+ Coverage    44.94%   45.04%   +0.10%     
===========================================
  Files          753      755       +2     
  Lines        14665    14618      -47     
  Branches      2130     2096      -34     
===========================================
- Hits          6591     6585       -6     
+ Misses        7771     7734      -37     
+ Partials       303      299       -4     
Flag Coverage Δ
e2e 45.00% <ø> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Dec 15 '22 18:12 codecov[bot]

Hi! Could you remove folder helpers and bring functions to file useFilteredApps.ts where is used this two functions? Names like helper doesn't "help" to understand what is happening there in terms of code.

The folder is not supposed to help, but the name of the callback is. That's why they have their own files because you'll be able to know their use based on the name of the callback of the .filter functions.

rique223 avatar Jan 31 '23 20:01 rique223