incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[Improvement] Unit tests support mocking the ShuffleServerNettyHandler class

Open rickyma opened this issue 1 year ago • 3 comments

Code of Conduct

Search before asking

  • [X] I have searched in the issues and found no similar issues.

What would you like to be improved?

Unit tests support mocking the ShuffleServerNettyHandler class in order to better cover the business code for the netty part.

We can search for TODO skip validating for GRPC_NETTY, needs to mock ShuffleServerNettyHandler in our codes.

How should we improve?

No response

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

rickyma avatar Jun 18 '24 15:06 rickyma

This is really important in Netty mode. Anyone is welcome to pick this up.

rickyma avatar Jun 25 '24 17:06 rickyma

This is really important in Netty mode. Anyone is welcome to pick this up.

When running in prod, we currently use Netty mode due to https://github.com/apache/incubator-uniffle/issues/1651, so this issue is very important. Because we lack the ability to test Netty business codes using UTs. If you are interested, I can assign this issue to you. That will be of great help.

@maobaolong

rickyma avatar Jul 02 '24 12:07 rickyma

@rickyma Will take a look at this issue, thank you!

maobaolong avatar Jul 03 '24 02:07 maobaolong