incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[#1651] improvement(netty): Set Netty as the default server type

Open rickyma opened this issue 1 year ago • 3 comments

What changes were proposed in this pull request?

Set Netty as the default server type.

Why are the changes needed?

For: https://github.com/apache/incubator-uniffle/issues/1651.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

rickyma avatar Jul 17 '24 07:07 rickyma

MR/TEZ don't support Netty now. I hesitate to make it default.

jerqi avatar Jul 17 '24 08:07 jerqi

Test Results

 3 011 files  ±0   3 011 suites  ±0   6h 42m 2s ⏱️ - 1m 24s  1 177 tests ±0   1 173 ✅  - 3   1 💤 ±0  3 ❌ +3  14 914 runs  ±0  14 893 ✅  - 6  15 💤 ±0  6 ❌ +6 

For more details on these failures, see this check.

Results for commit 4e96dd25. ± Comparison against base commit dac1065f.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 17 '24 08:07 github-actions[bot]

OK, I'll keep this PR here. When it is ready, anyone can modify on top of this PR.

rickyma avatar Jul 17 '24 08:07 rickyma

@maobaolong I think you can continue working on this PR.

rickyma avatar Oct 30 '24 03:10 rickyma

@rickyma Ok, thanks for the effort before!

maobaolong avatar Oct 30 '24 04:10 maobaolong

MR/TEZ don't support Netty now. I hesitate to make it default.

@jerqi I think maybe we can merge this now? I've fixed the conflicts btw.

rickyma avatar Mar 22 '25 07:03 rickyma

MR/TEZ don't support Netty now. I hesitate to make it default.

@jerqi I think maybe we can merge this now? I've fixed the conflicts btw.

Yes, I think we can merge this. cc @maobaolong @zhengchenyu

jerqi avatar Mar 24 '25 02:03 jerqi

MR/TEZ don't support Netty now. I hesitate to make it default.

@jerqi I think maybe we can merge this now? I've fixed the conflicts btw.

Yes, I think we can merge this. cc @maobaolong @zhengchenyu

I agree! We've already used Netty.

zhengchenyu avatar Mar 24 '25 02:03 zhengchenyu

Merged. Thanks for your reviews @jerqi @zhengchenyu @zuston

rickyma avatar Mar 24 '25 03:03 rickyma

It seems the MR integretion tests for netty part have failed after setting Netty as the default server type.

Could you please help to fix this? I'm not familiar with MR's part. Something more might need to be done in this https://github.com/apache/uniffle/pull/2016? @qijiale76 @zhengchenyu

rickyma avatar Mar 24 '25 06:03 rickyma

It seems the MR integretion tests for netty part have failed after setting Netty as the default server type.

Could you please help to fix this? I'm not familiar with MR's part. Something more might need to be done in this #2016? @qijiale76 @zhengchenyu

This has nothing to do with #2016. In this pr, the default netty port is chanaged. But for grpc server which netty is disable, the netty port will be used to form the server id, then fail. See more See #2421 for details.

zhengchenyu avatar Mar 31 '25 11:03 zhengchenyu