Richard Cissée

Results 16 comments of Richard Cissée

I'm interested in this as well. Is this still being worked on?

A workaround that works for me (at least in an older version 2.6.1) is to disable the custom scaling for this specific application. This doesn't even affect the text and...

I consider this to be a simple fix. Is there anything that keeps it from getting accepted? I'd appreciate some feedback.

We should maybe just use "(xx years after death)" in that case, as for other events occuring after the death of the individual. Also, for from/to dates, maybe in general...

Are there any plans to address this issue? I'll handle it in Vesta otherwise. This should be part of a larger effort in order to also fix e.g. #3358.

What do I have to do to convince you to accept these PRs? [Again, see our earlier discussion here.](https://github.com/fisharebest/webtrees/pull/4206)

No, of course that's fine if they change - it's still easier for me (otherwise I would have to copy all those changes anyway).

Perhaps just replace the entire check (including the xref part), i.e. [lines 94-96](https://github.com/fisharebest/webtrees/blob/e820a2a4359ba8c938798bfe7bd0430398d3ec2a/app/Http/RequestHandlers/GedcomRecordPage.php#L94) with this: ``` $genericRecord = Registry::gedcomRecordFactory()->new($xref, '', null, $tree); if ($record->url() !== $genericRecord->url()) { return redirect($record->url()); }...

That would work as well, as custom factories always return subclasses of the respective type (I assumed above they could return any subclass of GedcomRecord, but that's not the case).

I don't think this is necessary - why don't you just adjust `customModuleLatestVersion()` in your custom module, according to your specific needs? (Adjustments of that method are required anyway in...