webtrees icon indicating copy to clipboard operation
webtrees copied to clipboard

Change access modifiers for easier extensibility of module

Open ric2016 opened this issue 2 years ago • 2 comments

Codecov Report

Merging #4321 (6875c35) into main (14dc37d) will not change coverage. The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #4321   +/-   ##
=========================================
  Coverage     31.84%   31.84%           
  Complexity    11098    11098           
=========================================
  Files          1091     1091           
  Lines         39143    39143           
=========================================
  Hits          12466    12466           
  Misses        26677    26677           
Impacted Files Coverage Δ
app/Module/PedigreeMapModule.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14dc37d...6875c35. Read the comment docs.

codecov[bot] avatar Apr 20 '22 20:04 codecov[bot]

What do I have to do to convince you to accept these PRs? Again, see our earlier discussion here.

ric2016 avatar May 06 '22 21:05 ric2016

What do I have to do to convince you to accept these PRs?

That you will not be upset if/when I change these internal/implementation details...

fisharebest avatar Nov 25 '22 10:11 fisharebest

No, of course that's fine if they change - it's still easier for me (otherwise I would have to copy all those changes anyway).

ric2016 avatar Nov 25 '22 17:11 ric2016