Fix #4282.

[ric2016]

See issue #4282.

[codecov[bot]]

Codecov Report

Merging #4459 (dc021cd) into main (eeec557) will not change coverage. The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #4459   +/-   ##
=========================================
  Coverage     31.51%   31.51%           
- Complexity    11206    11207    +1     
=========================================
  Files          1105     1105           
  Lines         39604    39604           
=========================================
  Hits          12481    12481           
  Misses        27123    27123           

Impacted Files	Coverage Δ
app/Fact.php	5.03% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eeec557...dc021cd. Read the comment docs.

[ric2016]

I consider this to be a simple fix. Is there anything that keeps it from getting accepted? I'd appreciate some feedback.

[fisharebest]

I consider this to be a simple fix. Is there anything that keeps it from getting accepted? I'd appreciate some feedback.

Sorry - been busy.

I think the original summary() function out to be a view. It creates formatted HTML, and doesn't belong in the Fact class.

For the "delete confirmation" text, we're creating formatted HTML, then stripping it off. Since we just need the fact's type/value/date/place and since we only need it in one place, I think it should probably go inline here.

[fisharebest]

We already have a function to create the required text: Fact::name(). I had forgotten this function exists...