Emir Ribić

Results 41 comments of Emir Ribić

What's `oryxBuildBinary`? I'm against this, but just a note that it would be much simpler and more readable if you want to achieve this, add a check at beginning (if...

This is a breaking change, as it changes the signature of NewRequest. I assume that's used externally (as it's public/exposed). The added validation doesn't seem worthy of a breaking change.

Looks good to me. Please update changelog as well.

In essence, this would require us to change `Scope.request` from *http.Request to `sentry.Request` as that's what used underneath in the event (we convert *http.Request to sentry.Request to use for event...

I fixed the gin panic issue. But with these changes, in `gin`, the request body is not properly set on the event. I'll keep debugging this.

> I fixed the gin panic issue. But with these changes, in `gin`, the request body is not properly set on the event. I'll keep debugging this. Resolved.

> There are some breaking changes in here we need to call out on the changelog. Besides this, LGTM! Are you referring to moving the WrapResponseWriter from `sentryhttp` to `sentry`?...

@cleptric Perhaps we should move the Hijacker interface to `/internal`?

Yes I can. Before I change the interface to support v1, I'm curious if we can update to v3? Is that an option?

Upgraded negroni to latest version in #885. This worked just fine: https://gist.github.com/ribice/95934b3c209b9692efc4b50b91d5dd4a