sentry-go icon indicating copy to clipboard operation
sentry-go copied to clipboard

fix(http): use route name from 'r.Pattern' instead

Open aldy505 opened this issue 1 year ago • 3 comments

I have a Go project running latest Chi - v5.1.0 and Go 1.22.x. Every root span becomes: GET /*/*/*. I don't think this is an issue on Chi though. Hoping this would fix that.

aldy505 avatar Aug 25 '24 10:08 aldy505

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.90%. Comparing base (e5d46d5) to head (f4e8894). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #875      +/-   ##
==========================================
- Coverage   82.94%   82.90%   -0.05%     
==========================================
  Files          53       55       +2     
  Lines        4592     4603      +11     
==========================================
+ Hits         3809     3816       +7     
- Misses        630      633       +3     
- Partials      153      154       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 25 '24 10:08 codecov[bot]

So http.Request.Pattern only exists on Go 1.23, yet the route matching exists on Go 1.22 :/

aldy505 avatar Aug 26 '24 02:08 aldy505

Looks good to me. Please update changelog as well.

ribice avatar Aug 28 '24 07:08 ribice