Emir Ribić

Results 43 comments of Emir Ribić

@Sophie1142 Could you please provide a way for me to reproduce this? Thanks.

I've found one recently, but it hosts images only. https://www.previewdump.com/uploads/view/10002

I tried downgrading Sentry to 0.27.0 and upgrading it to 0.28.1 - both have the same issue. Will investigate further.

> LGTM, anything else you want to add here? No, just haven't had the chance to test it e2e.

![CleanShot 2024-07-03 at 12 30 10](https://github.com/getsentry/sentry-go/assets/5403700/abd48cf1-d952-4f72-8b73-12a2479aabd2) These are visible in spans. Ready for review/merge now.

@cleptric Just realised we can't use 1.18 with exp/slog (requires at least 1.19): https://github.com/golang/go/issues/57113

> Let's make this it's own package. You can update https://github.com/getsentry/sentry-go/blob/master/.craft.yml and I'll add it to our release registry. I updated .craft.yml and made `slog` integration a module. Is there...

@cleptric Shall I update the `vet` script in Makefile to skip if no go files are found (which is the case for slog in Go

Waiting for #898 to be merged before I merge this.